Skip to content

Fixed renderer getting out of sync #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2019
Merged

Fixed renderer getting out of sync #3472

merged 3 commits into from
Feb 12, 2019

Conversation

sanketsingh24
Copy link
Contributor

Closes #3265

  • This PR fixes the bug in which the aspect ratio was not being maintained when resizing. The error was the child _renderer in _curCamera was getting out of sync after pop() call in setattributes().
  • @Spongman suggested the solution for this bug. Also added the sketch I was using in manual tests.
  • Need suggestions for whether the sketch should be merged, and if yes, where it should be present.

Spongman
Spongman reviewed Jan 23, 2019
View reviewed changes
stalgiag
stalgiag requested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this together! Just a few small changes requested.

@stalgiag stalgiag merged commit 69a3af7 into processing:master Feb 12, 2019
@stalgiag
Copy link
Contributor

Thank you for the contribution!

@sanketsingh24 sanketsingh24 deleted the fix-setattributes_resizeCanvas branch February 12, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spongman Spongman Spongman left review comments

@stalgiag stalgiag stalgiag approved these changes

Assignees
No one assigned
Labels
Area:WebGL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webgl: setAttributes() breaks resizeCanvas aspect
4 participants
@sanketsingh24 @stalgiag @Spongman @outofambit