Skip to content

Progress bar in SDK updater is indeterminate #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeanticode opened this issue Jul 27, 2017 · 3 comments
Closed

Progress bar in SDK updater is indeterminate #362

codeanticode opened this issue Jul 27, 2017 · 3 comments

Comments

@codeanticode
Copy link
Contributor

codeanticode commented Jul 27, 2017

Right now, the progress bar in the SDK updater is set to indeterminate mode, because the getFraction() method in the ConsoleProgressIndicator object used in the query and download tasks returns 0.

This code from the Android Plugin for IntelliJ IDEA can help understanding more advanced users of the progress indicator and the download functionality:

My impression is that the current progress has to be set somehow using progress.setFraction(), so it can then can be retrieved with progress.getFraction().

@codeanticode codeanticode changed the title Progress bar in SDK udater is indeterminate Progress bar in SDK updater is indeterminate Jul 27, 2017
@DeerajTheepshi
Copy link
Contributor

@codeanticode ,
The link that "This code" refers to has been removed(404 Error). Can you check it ?

@codeanticode
Copy link
Contributor Author

@DeerajTheepshi thanks for flagging this, will take a look shortly

@DeerajTheepshi
Copy link
Contributor

@codeanticode and @kfrajer , The getFraction function works . I'm not sure why this issue was raised , but it seems to be working fine. The setFraction method is taken care by the android libraries. So it does not pose a problem. The only issue is that the same consoleProgress object is used for 3 different process :

  • Loading the repo
  • Preparing the installer files and the install process itself
  • Completion of the install process

As a result of which, the progressBar would load from 0 ,three times. We could notify the user about these three stages via the status text on the updater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants