Consider to apply some clippy pedantic rules

[qarmin]

Looks that some pedantic rules are quite useful to improve and unify style and even sometimes performance

cargo +nightly clippy -- -Wclippy::pedantic

https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms: x118
https://rust-lang.github.io/rust-clippy/master/index.html#module_name_repetitions: x78
https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else: x47
https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate: x41
https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else: x32
https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown: x30
https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc: x23
https://rust-lang.github.io/rust-clippy/master/index.html#match_bool: x22
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls: x17
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps: x13
https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation: x12
https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned: x11
https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value: x11
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop: x11
https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss: x9
https://rust-lang.github.io/rust-clippy/master/index.html#fn_params_excessive_bools: x7
https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding: x6
https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines: x6
https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else: x6
https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss: x6
https://rust-lang.github.io/rust-clippy/master/index.html#unused_self: x4
https://rust-lang.github.io/rust-clippy/master/index.html#struct_excessive_bools: x4
https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor: x4
https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_wrap: x4
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else: x3
https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or: x3
https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns: x2
https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref: x2
https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc: x2
https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone: x2
https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs: x2
https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless: x2
https://rust-lang.github.io/rust-clippy/master/index.html#similar_names: x1
https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants: x1
https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp: x1
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop: x1

some of this warnings are too strict, so instead all I choose manually only the most usable

cargo +nightly clippy -- -Wclippy::bool_to_int_with_if -Wclippy::checked_conversions -Wclippy::cloned_instead_of_copied -Wclippy::explicit_deref_methods -Wclippy::explicit_into_iter_loop -Wclippy::explicit_iter_loop -Wclippy::filter_map_next -Wclippy::flat_map_option -Wclippy::float_cmp -Wclippy::from_iter_instead_of_collect -Wclippy::if_not_else -Wclippy::implicit_clone -Wclippy::inconsistent_struct_constructor -Wclippy::inefficient_to_string -Wclippy::invalid_upcast_comparisons -Wclippy::iter_not_returning_iterator -Wclippy::large_digit_groups -Wclippy::large_stack_arrays -Wclippy::large_types_passed_by_value -Wclippy::linkedlist -Wclippy::macro_use_imports -Wclippy::manual_assert -Wclippy::manual_instant_elapsed -Wclippy::manual_let_else -Wclippy::manual_ok_or -Wclippy::manual_string_new -Wclippy::map_unwrap_or -Wclippy::match_bool -Wclippy::match_same_arms -Wclippy::match_wildcard_for_single_variants -Wclippy::maybe_infinite_iter -Wclippy::mismatching_type_param_order -Wclippy::mut_mut -Wclippy::naive_bytecount -Wclippy::needless_bitwise_bool -Wclippy::needless_continue -Wclippy::needless_for_each -Wclippy::needless_pass_by_value -Wclippy::no_effect_underscore_binding -Wclippy::range_minus_one -Wclippy::range_plus_one -Wclippy::redundant_closure_for_method_calls -Wclippy::redundant_else -Wclippy::ref_option_ref -Wclippy::return_self_not_must_use -Wclippy::same_functions_in_if_condition -Wclippy::semicolon_if_nothing_returned -Wclippy::single_match_else -Wclippy::stable_sort_primitive -Wclippy::string_add_assign -Wclippy::uninlined_format_args -Wclippy::unnecessary_box_returns -Wclippy::unnecessary_join -Wclippy::unnecessary_wraps -Wclippy::unnested_or_patterns -Wclippy::unreadable_literal -Wclippy::unsafe_derive_deserialize -Wclippy::unused_async -Wclippy::unused_self -Wclippy::used_underscore_binding -Wclippy::zero_sized_map_values

https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms: x118
https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else: x47
https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else: x32
https://rust-lang.github.io/rust-clippy/master/index.html#match_bool: x22
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls: x17
https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps: x13
https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned: x11
https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value: x11
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_iter_loop: x11
https://rust-lang.github.io/rust-clippy/master/index.html#used_underscore_binding: x6
https://rust-lang.github.io/rust-clippy/master/index.html#if_not_else: x6
https://rust-lang.github.io/rust-clippy/master/index.html#unused_self: x4
https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor: x4
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else: x3
https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or: x3
https://rust-lang.github.io/rust-clippy/master/index.html#unnested_or_patterns: x2
https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone: x2
https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs: x2
https://rust-lang.github.io/rust-clippy/master/index.html#match_wildcard_for_single_variants: x1
https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp: x1
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_into_iter_loop: x1

[lig]

@qarmin Thanks for your suggestion!

Would you mind submitting a PR showing those rules (some of them) applied? I think, seeing a possible outcome could help deciding on accepting this rules.