Skip to content

fix stubtest issue post-merge #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix stubtest issue post-merge #711

merged 2 commits into from
Jun 28, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Looks like #702 hit a cache issue where the last-minute rust change wasn't caught by the new stubtest lint. So I've fixed the issue and removed the cache line.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 28, 2023

CodSpeed Performance Report

Merging #711 dh/stub-fixup (1bd9198) will degrade performances by 10.82%.

Summary

🔥 0 improvements
❌ 1 regressions
✅ 124 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/stub-fixup Change
test_date_from_str 23 µs 25.8 µs -10.82%

@davidhewitt
Copy link
Contributor Author

I pushed a second commit to resolve a clippy issue from conflict of #691 and #695

@davidhewitt
Copy link
Contributor Author

(will assume it's trivial enough that I'll proceed to merge)

@davidhewitt davidhewitt enabled auto-merge (squash) June 28, 2023 19:22
@davidhewitt davidhewitt merged commit 54daab7 into main Jun 28, 2023
@davidhewitt davidhewitt deleted the dh/stub-fixup branch June 28, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants