Skip to content

add note to migration guide about changes to AnyUrl etc #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 12, 2023

Change Summary

As per the title - add a short comment informing users searching the migration guide about the changes to Url.

Related issue number

Ref #6593, which is an example of user experiencing friction due to the change.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 833a8c6
Status: ✅  Deploy successful!
Preview URL: https://c3be4016.pydantic-docs2.pages.dev
Branch Preview URL: https://dh-urls-migration.pydantic-docs2.pages.dev

View logs

@davidhewitt
Copy link
Contributor Author

please review

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jul 12, 2023
@pydantic-hooky pydantic-hooky bot assigned davidhewitt and unassigned adriangb Jul 12, 2023
Co-authored-by: Marcelo Trylesinski <[email protected]>
@davidhewitt davidhewitt merged commit b0058ad into main Jul 12, 2023
@davidhewitt davidhewitt deleted the dh/urls-migration branch July 12, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author revision awaiting changes from the PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants