Skip to content

Add jupyter-sphinx to requirements-dev.txt and conda envs #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canyon289 opened this issue Jun 3, 2022 · 1 comment · Fixed by #5901
Closed

Add jupyter-sphinx to requirements-dev.txt and conda envs #5845

canyon289 opened this issue Jun 3, 2022 · 1 comment · Fixed by #5901

Comments

@canyon289
Copy link
Member

Description of your problem

Installed new environment and it seems dependencies are missing for doc build. One identified below, not sure if there are others

image

Please provide the full traceback.

Extension error:
Could not import extension jupyter_sphinx (exception: No module named 'jupyter_sphinx')
make: *** [Makefile:62: html] Error 2

Versions and main components

  • PyMC/PyMC3 Version:
  • Aesara/Theano Version:
  • Python Version:
  • Operating system:
  • How did you install PyMC/PyMC3: (conda/pip)
@OriolAbril
Copy link
Member

OriolAbril commented Jun 4, 2022

jupyter sphinx used to be a dependency of myst-nb, since the last myst-nb release it is not anymore. We need to add it because we use both explicitly.

We need to rethink how we manage/bundle dependencies, which we are tracking in #5074. I'd restrict this issue to adding jupyter-sphinx to the conda envs and requirements-dev.

Note: if we don't fix this the readthedocs build will break at some point. It is still working only because it uses an old myst-nb version that depends on jupyter-sphinx. I also know there are no other dependencies to be added because readthedocs uses the 3.8 conda env to build the docs and it manages to do so at every commit and PR preview

@OriolAbril OriolAbril changed the title Add requirements needed for doc build to requirements-dev.txt or perhaps a new requirements-docs.txt Add jupyter-sphinx to requirements-dev.txt and conda envs Jun 4, 2022
ricardoV94 added a commit to ricardoV94/pymc that referenced this issue Jun 17, 2022
twiecki pushed a commit that referenced this issue Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants