replace deprecationwarning with futurewarning #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5109 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 87 87
Lines 14008 14008
=======================================
Hits 10903 10903
Misses 3105 3105
|
|
Again, I think most of these should be deleted, let's open an issue for those. |
thomasaarholt
added a commit
to thomasaarholt/pymc
that referenced
this pull request
Sep 3, 2024
Removing these to reduce cognitive load for an eventual migration to a function-based distribution. These were deprecated in pymc-devs#5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe.
11 tasks
ricardoV94
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Remove deprecated Distribution kwargs Removing these to reduce cognitive load for an eventual migration to a function-based distribution. These were deprecated in #5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe. * Replace deprecated testval arg with initval in test I keep the test, since it seems to cover behaviour not tested elsewhere.
vandalt
pushed a commit
to vandalt/pymc
that referenced
this pull request
May 14, 2025
* Remove deprecated Distribution kwargs Removing these to reduce cognitive load for an eventual migration to a function-based distribution. These were deprecated in pymc-devs#5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe. * Replace deprecated testval arg with initval in test I keep the test, since it seems to cover behaviour not tested elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarningis intended for other developers andFutureWarningfor users. When in doubt is probably safer to go withFutureWarning.