Skip to content

Fix minor typos #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Fix minor typos #5110

merged 3 commits into from
Nov 3, 2021

Conversation

canyon289
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #5110 (041e21d) into main (05aa247) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5110   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files          87       87           
  Lines       14008    14008           
=======================================
  Hits        10900    10900           
  Misses       3108     3108           

@canyon289 canyon289 changed the title Fix minor typo [WIP] Fix minor typo Oct 28, 2021
@canyon289
Copy link
Member Author

Noticing theres other small fixes needed here. Marking WIP till I can get to them all later

@canyon289 canyon289 changed the title [WIP] Fix minor typo Fix minor typos Oct 29, 2021
@canyon289
Copy link
Member Author

Alright were good now

@michaelosthege
Copy link
Member

I must say I'm not a fan of not mentioning version numbers and just going with the "PyMC" vs. "PyMC3" distinction.

A sentence such as

This is effectively the PyMC replacement for Distribution.random.

could easily confuse someone who is not aware that there once was a "PyMC3" and that the lack of the 3 indicates that pymc >=4 is meant.

Maybe we can instead try to mention v3 explicitly like this?

This is effectively the replacement of the old Distribution.random API from v3.x.

@aloctavodia
Copy link
Member

I agree with @michaelosthege we should not make a distinction between PyMC3 and PyMC, there is only one project/software/package/tool and that is PyMC. If we want to contrast features from different versions we should explicitly use the version numbers like 3.x vs 4.x or <4.0, etc

@canyon289
Copy link
Member Author

Ok! Will update

@ricardoV94
Copy link
Member

@canyon289 Can we merge this or are there any other changes you had in mind?

@twiecki twiecki merged commit 21e1998 into main Nov 3, 2021
@twiecki twiecki deleted the typo_fix branch November 3, 2021 21:17
@canyon289
Copy link
Member Author

Ah I see we merged this, was going to update based on discussion in our lab meeting. Noting that within our community we still are unclear about how to refer to the distinctions of PyMC

Between subsets of us we still use

  • PyMC vs PyMC3
  • PyMC 4.x vs PyMC 3.x (and drop PyMC3 altogether)
  • PyMC V4 vs PyMC V3 (and drop PyMC3 altogether)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants