Skip to content

Remove size parameter from sample_posterior_predictive #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

Remove size parameter from sample_posterior_predictive #5772

merged 1 commit into from
May 18, 2022

Conversation

ricardoV94
Copy link
Member

Closes #5771

Seems like this was mostly a leftover from V3 and is not really being used anywhere

@codecov
Copy link

codecov bot commented May 17, 2022 •
edited
Loading

Codecov Report

Merging #5772 (34b61d3) into main (862bd05) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5772      +/-   ##
==========================================
- Coverage   89.27%   89.27%   -0.01%     
==========================================
  Files          74       74              
  Lines       13813    13809       -4     
==========================================
- Hits        12332    12328       -4     
  Misses       1481     1481
Impacted Files Coverage Δ
pymc/sampling.py 88.34% <100.00%> (-0.06%) ⬇️

@ricardoV94
Copy link
Member Author

Flaky test is back #5739, opened a PR to fix it: #5773

@ricardoV94 ricardoV94 force-pushed the remove_size_post_pred branch from 44c7666 to 6b1e67a Compare May 17, 2022 12:56
@ricardoV94 ricardoV94 mentioned this pull request May 17, 2022
Closed
@ricardoV94 ricardoV94 requested a review from OriolAbril May 17, 2022 13:17
@ricardoV94 ricardoV94 force-pushed the remove_size_post_pred branch from 6b1e67a to 34b61d3 Compare May 18, 2022 07:20
lucianopaz
lucianopaz approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoV94 ricardoV94 merged commit 817f457 into pymc-devs:main May 18, 2022
@ricardoV94 ricardoV94 deleted the remove_size_post_pred branch June 6, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianopaz lucianopaz lucianopaz approved these changes

@OriolAbril OriolAbril Awaiting requested review from OriolAbril

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove size option from sample_posterior_predictive
2 participants
@ricardoV94 @lucianopaz