-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix docker image build #5977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker image build #5977
Conversation
@michaelosthege had some ideas of how to test this. |
Codecov Report
@@ Coverage Diff @@
## main #5977 +/- ##
==========================================
+ Coverage 87.31% 89.35% +2.04%
==========================================
Files 73 73
Lines 13253 13251 -2
==========================================
+ Hits 11572 11841 +269
+ Misses 1681 1410 -271
|
@twiecki please review & merge #5976 first. We don't want to trigger the test pipelines all the time. @symeneses once that's merged please rebase onto |
@symeneses that other PR is merged now, so you could rebase now & start testing the steps right in the PR. |
I can test now. I will add the changes from #5975 |
74847ed
to
7c0bf65
Compare
It looks like it's working now, it failed in my fork as I don't have the secrets. Let me know if everything is fine to remove the comments. |
Lookig good! This pipeline run https://github.com/pymc-devs/pymc/runs/7392065463?check_suite_focus=true confirmed the build and test steps. Now let's uncomment the commented-out sections and then we can sqash-merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What is this PR about?
It fixes #5974.
In the local test, the step was working but it looks like the indentation of
tags
is wrong....
Checklist
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance