Skip to content

Fix docker image build #5977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2022
Merged

Fix docker image build #5977

merged 10 commits into from
Jul 18, 2022

Conversation

symeneses
Copy link
Contributor

What is this PR about?

It fixes #5974.
In the local test, the step was working but it looks like the indentation of tags is wrong.

...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • ...

@twiecki
Copy link
Member

twiecki commented Jul 15, 2022

@michaelosthege had some ideas of how to test this.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5977 (74847ed) into main (2a9e86c) will increase coverage by 2.04%.
The diff coverage is n/a.

❗ Current head 74847ed differs from pull request most recent head 7972cb5. Consider uploading reports for the commit 7972cb5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5977      +/-   ##
==========================================
+ Coverage   87.31%   89.35%   +2.04%     
==========================================
  Files          73       73              
  Lines       13253    13251       -2     
==========================================
+ Hits        11572    11841     +269     
+ Misses       1681     1410     -271     
Impacted Files Coverage Δ
pymc/sampling_jax.py 96.93% <0.00%> (-0.04%) ⬇️
pymc/distributions/continuous.py 97.89% <0.00%> (+0.10%) ⬆️
pymc/sampling.py 82.41% <0.00%> (+0.11%) ⬆️
pymc/distributions/multivariate.py 92.03% <0.00%> (+0.98%) ⬆️
pymc/distributions/discrete.py 99.21% <0.00%> (+1.56%) ⬆️
pymc/util.py 77.24% <0.00%> (+2.39%) ⬆️
pymc/printing.py 26.66% <0.00%> (+4.76%) ⬆️
pymc/step_methods/hmc/quadpotential.py 80.69% <0.00%> (+6.93%) ⬆️
pymc/model.py 88.20% <0.00%> (+12.05%) ⬆️
pymc/model_graph.py 93.70% <0.00%> (+13.38%) ⬆️
... and 1 more

@michaelosthege
Copy link
Member

@twiecki please review & merge #5976 first. We don't want to trigger the test pipelines all the time.

@symeneses once that's merged please rebase onto main and also include the changes I did in #5975.

@michaelosthege
Copy link
Member

@symeneses that other PR is merged now, so you could rebase now & start testing the steps right in the PR.
Let me know if you have time (or not) then we can decide whether to proceed here, or over in #5975 :)

@symeneses
Copy link
Contributor Author

@symeneses that other PR is merged now, so you could rebase now & start testing the steps right in the PR. Let me know if you have time (or not) then we can decide whether to proceed here, or over in #5975 :)

I can test now. I will add the changes from #5975

@symeneses symeneses force-pushed the fix/gh-docker-image branch from 74847ed to 7c0bf65 Compare July 18, 2022 14:17
@symeneses
Copy link
Contributor Author

It looks like it's working now, it failed in my fork as I don't have the secrets.

Let me know if everything is fine to remove the comments.

@michaelosthege
Copy link
Member

Lookig good! This pipeline run https://github.com/pymc-devs/pymc/runs/7392065463?check_suite_focus=true confirmed the build and test steps.

Now let's uncomment the commented-out sections and then we can sqash-merge

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@twiecki twiecki merged commit 710aee3 into pymc-devs:main Jul 18, 2022
@symeneses symeneses deleted the fix/gh-docker-image branch July 18, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image GH action build is broken
3 participants