Switch backend to PyTensor #6365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
e2009ba to
5e3035a
Compare
added 2 commits
December 4, 2022 12:17
8a80bc8 to
630c29a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6365 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 132 132
Lines 26740 26741 +1
=======================================
+ Hits 25330 25331 +1
Misses 1410 1410
|
ricardoV94
approved these changes
Dec 4, 2022
ericmjl
approved these changes
Dec 4, 2022
OriolAbril
reviewed
Dec 6, 2022
| @@ -74,7 +74,7 @@ Important modules to note are | |||
| a random variable distribution from a likelihood distribution. | |||
|
|
|||
| * `logprob.py`: This contains the log probability logic for the distributions themselves. | |||
| The log probability calculation is deferred to Aesara | |||
| The log probability calculation is deferred to PyTensor | |||
There was a problem hiding this comment.
I think this is at least partially incorrect as "non-basic" distributions have their PPLs in pymc (logprob module)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Swapping the backend from Aesara to PyTensor.
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance