Skip to content

Use ordered_univariate in documentation example of NormalMixture #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

mrpg
Copy link
Contributor

@mrpg mrpg commented Aug 1, 2023

What is this PR about?
The documentation example of a normal mixture used an outdated path in the transform argument of pm.Normal.

Checklist

Major / Breaking Changes

  • None

New features

  • None

Bugfixes

  • None

Documentation

  • Instead of pm.transforms.ordered, an Ordered is instantiated and used in its place.

Maintenance

  • None

📚 Documentation preview 📚: https://pymc--6842.org.readthedocs.build/en/6842/

@welcome
Copy link

welcome bot commented Aug 1, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #6842 (e6392bd) into main (5c600c7) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head e6392bd differs from pull request most recent head 54a0998. Consider uploading reports for the commit 54a0998 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6842   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          96       96           
  Lines       16378    16378           
=======================================
  Hits        15074    15074           
  Misses       1304     1304           
Files Changed Coverage Δ
pymc/distributions/mixture.py 94.97% <ø> (ø)

@ricardoV94 ricardoV94 merged commit ccad4c8 into pymc-devs:main Aug 6, 2023
@welcome
Copy link

welcome bot commented Aug 6, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

@ricardoV94 ricardoV94 changed the title Use new transforms taxonomy in documentation example of NormalMixture Use ordered_univariate in documentation example of NormalMixture Aug 6, 2023
@ricardoV94 ricardoV94 added the docs label Aug 6, 2023
@ricardoV94
Copy link
Member

Thanks @mrpg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants