Fix logcdf and icdf derivations for non-monotonically increasing transformations #6850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6597 was only valid for strictly monotonically increasing transformations.
This PR fixes the derivations for monotonically decreasing transformations and adds a special case for logcdf of negative powers for distributions that allow negative values.
Also fixes the derivations for cosh transformed variables as that is not injective (CC @LukeLB)
Refactored a bit the test module with Test classes. It was growing a tad too unmanageable.
The first two commits are just refactoring and bugfixes come after
📚 Documentation preview 📚: https://pymc--6850.org.readthedocs.build/en/6850/