-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Improve blackjax sampling integration #6963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Oct 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6963 +/- ##
==========================================
- Coverage 92.12% 92.09% -0.03%
==========================================
Files 100 100
Lines 16859 16875 +16
==========================================
+ Hits 15531 15541 +10
- Misses 1328 1334 +6
|
@jessegrabowski FYI the progress bar is partially working for both warm up and sampling. |
twiecki
approved these changes
Oct 23, 2023
ricardoV94
reviewed
Oct 23, 2023
ricardoV94
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6550
What is this PR about?
Adding more fine tune control in blackjax sampling.
After this PR:
Checklist
Major / Breaking Changes
None
New features
More option in Blackjax sampling
Bugfixes
None
Documentation
None
Maintenance
None
📚 Documentation preview 📚: https://pymc--6963.org.readthedocs.build/en/6963/