Skip to content

Update pymc3\examples #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2018
Merged

Update pymc3\examples #2947

merged 6 commits into from
Apr 24, 2018

Conversation

junpenglao
Copy link
Member

Rerun all examples under current master

  • fix examples that report error
  • use more informative prior and/or alternative init to avoid divergence

Junpeng Lao added 6 commits April 23, 2018 09:41
Move custom logp outside of model block to avoide `AttributeError: Can't pickle local object 'build_model.<locals>.logp'`
- Change scale of prior
- increase tuning and target_accept
Note that there are still ~5 divergences per 1000 samples after tunning, further reparameterization is necessary.
No more divergence with more informative priors.
avoid `ValueError: Mass matrix contains zeros on the diagonal.`
@junpenglao junpenglao changed the title Update \pymc3\examples Update pymc3\examples Apr 23, 2018
@fonnesbeck
Copy link
Member

LGTM

@junpenglao junpenglao merged commit c1d8d23 into pymc-devs:master Apr 24, 2018
@junpenglao junpenglao deleted the Update_examples branch April 24, 2018 04:50
agustinaarroyuelo pushed a commit to agustinaarroyuelo/pymc3 that referenced this pull request Feb 8, 2019
* Update arbitrary_stochastic.py

Move custom logp outside of model block to avoide `AttributeError: Can't pickle local object 'build_model.<locals>.logp'`

* Reduce divergence

- Change scale of prior
- increase tuning and target_accept
Note that there are still ~5 divergences per 1000 samples after tunning, further reparameterization is necessary.

* remove unnecessary comments

* Change prior for model

No more divergence with more informative priors.

* Use more realistic prior to avoid divergence

* Change init for sample

avoid `ValueError: Mass matrix contains zeros on the diagonal.`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants