-
-
Notifications
You must be signed in to change notification settings - Fork 112
TST: test all rvs, not just tfp supported distributions #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Well this caught a few bugs, mostly to do with using the wrong dtype (e.g. tf.float32 instead of tf.float64). I'll try and debug this sometime this weekend. @canyon289 is it possible to get Coveralls to not comment like that? With PyMC3 it would should up in the same place that the Travis CI is. |
Disabled coverall comments. |
I think we need to split apart the tests for the tfp implemented distributions from the ones that pymc4 implements because for the pymc4 implemented distributions we do need to check for correctness, not just compilation |
@canyon289 I think we can keep these here but make sure we also add correctness tests in addition. |
…o test-tfp-unsupported
Currently the following code snippet fails with a
|
(Finally) ready for review. I excluded the I've also commented out the |
Looks great, thanks! We should open an issue with TFP about the problems we found. |
TFP issue filed here: tensorflow/probability#286 |
Nice, looks like there is a simple solution available. |
Closes #52
Building off of #49, this PR adds tests for all current distributions, not just those supported by tfp.