GitHub Action Ubuntu job doesn't check if generated files are up to date

[vstinner]

Previously, Travis CI was mandatory on Python PRs. Travis CI was made optional, and instead GHA Ubuntu was made required.

The problem is that only Travis CI checked if generated files are up to date:

  - eval "$(pyenv init -)"
  - pyenv global 3.8
  - PYTHON_FOR_REGEN=python3.8 make -j4 regen-all
  - changes=`git status --porcelain`
  - |
      # Check for changes in regenerated files
      if ! test -z "$changes"
      then
        echo "Generated files not up to date"
        echo "$changes"
        exit 1
      fi
  - make -j4
  - make pythoninfo

These commands should be copied and adapted in .github/workflows/build.yml.

Is there a volunteer to do that?

cc @FFY00 @ammaraskar

[FFY00]

I can look at this tomorrow 😊

[brettcannon]

I actually have plans to eventually make this a separate GitHub Action from the build workflows, but who the heck knows when I will have time to make that actually happen. 😄

[vstinner]

I actually have plans to eventually make this a separate GitHub Action from the build workflows, but who the heck knows when I will have time to make that actually happen. smile

I agree that it would be more reliable to not run "make regen-all" for the regular build. It's a good idea to have a separated job. It would also helper contributors to understand a job failure. Previous, the Travis CI error was not obvious.

[vstinner]

Oh, by the way, Travis CI also checks for "make smelly": ensure that all symbols exported by libpython start with "Py" or "_Py".

[FFY00]

@vstinner should this be part of build actions for every OS, or is it fine to just run it one time on one OS (in a separate action)?

[vstinner]

It's enough to test it on a single OS. I suggest to use Linux, since the checks were run on Linux previously.

A separated action would be better.

[vstinner]

@FFY00 created https://bugs.python.org/issue42212