Skip to content

Commit 4c7e09d

Browse files
authored
gh-114149: [Enum] revert #114160 and add more tuple-subclass tests (GH-114215)
This reverts commit 05e142b.
1 parent 9455403 commit 4c7e09d

File tree

2 files changed

+24
-9
lines changed

2 files changed

+24
-9
lines changed

Lib/enum.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ def __set_name__(self, enum_class, member_name):
250250
delattr(enum_class, member_name)
251251
# second step: create member based on enum_class
252252
value = self.value
253-
if type(value) is not tuple:
253+
if not isinstance(value, tuple):
254254
args = (value, )
255255
else:
256256
args = value
@@ -1777,7 +1777,7 @@ def convert_class(cls):
17771777
else:
17781778
# create the member
17791779
if use_args:
1780-
if type(value) is not tuple:
1780+
if not isinstance(value, tuple):
17811781
value = (value, )
17821782
member = new_member(enum_class, *value)
17831783
value = value[0]
@@ -1826,7 +1826,7 @@ def convert_class(cls):
18261826
else:
18271827
# create the member
18281828
if use_args:
1829-
if type(value) is not tuple:
1829+
if not isinstance(value, tuple):
18301830
value = (value, )
18311831
member = new_member(enum_class, *value)
18321832
value = value[0]

Lib/test/test_enum.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3201,19 +3201,34 @@ class NTEnum(Enum):
32013201
[x.value for x in NTEnum],
32023202
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
32033203
)
3204+
3205+
self.assertRaises(AttributeError, getattr, NTEnum.NONE, 'id')
3206+
#
3207+
class NTCEnum(TTuple, Enum):
3208+
NONE = 0, 0, []
3209+
A = 1, 2, [4]
3210+
B = 2, 4, [0, 1, 2]
3211+
self.assertEqual(repr(NTCEnum.NONE), "<NTCEnum.NONE: TTuple(id=0, a=0, blist=[])>")
3212+
self.assertEqual(NTCEnum.NONE.value, TTuple(id=0, a=0, blist=[]))
3213+
self.assertEqual(NTCEnum.NONE.id, 0)
3214+
self.assertEqual(NTCEnum.A.a, 2)
3215+
self.assertEqual(NTCEnum.B.blist, [0, 1 ,2])
3216+
self.assertEqual(
3217+
[x.value for x in NTCEnum],
3218+
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
3219+
)
32043220
#
32053221
class NTDEnum(Enum):
3206-
def __new__(cls, t_value):
3222+
def __new__(cls, id, a, blist):
32073223
member = object.__new__(cls)
3208-
member._value_ = t_value[0]
3209-
member.id = t_value[0]
3210-
member.a = t_value[1]
3211-
member.blist = t_value[2]
3224+
member.id = id
3225+
member.a = a
3226+
member.blist = blist
32123227
return member
32133228
NONE = TTuple(0, 0, [])
32143229
A = TTuple(1, 2, [4])
32153230
B = TTuple(2, 4, [0, 1, 2])
3216-
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: 0>")
3231+
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: TTuple(id=0, a=0, blist=[])>")
32173232
self.assertEqual(NTDEnum.NONE.id, 0)
32183233
self.assertEqual(NTDEnum.A.a, 2)
32193234
self.assertEqual(NTDEnum.B.blist, [0, 1 ,2])

0 commit comments

Comments
 (0)