Address review: fix performance issue in tee_copy()

Erlend E. Aasland · Erlend E. Aasland · commit 55cee70766f4 · 2021-01-03T10:38:00.000+01:00
diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c
@@ -787,8 +787,7 @@ tee_copy(teeobject *to, PyObject *Py_UNUSED(ignored))
 {
     teeobject *newto;
 
-    itertoolsmodule_state *state = itertoolsmodule_find_state_by_type(Py_TYPE(to));
-    newto = PyObject_GC_New(teeobject, state->tee_type);
+    newto = PyObject_GC_New(teeobject, Py_TYPE(to));
     if (newto == NULL)
         return NULL;
     Py_INCREF(to->dataobj);

Original file line number	Diff line number	Diff line change
`@@ -787,8 +787,7 @@ tee_copy(teeobject to, PyObject Py_UNUSED(ignored))`
`787`	`787`	`{`
`788`	`788`	`teeobject *newto;`
`789`	`789`
`790`		`- itertoolsmodule_state *state = itertoolsmodule_find_state_by_type(Py_TYPE(to));`
`791`		`- newto = PyObject_GC_New(teeobject, state->tee_type);`
	`790`	`+ newto = PyObject_GC_New(teeobject, Py_TYPE(to));`
`792`	`791`	`if (newto == NULL)`
`793`	`792`	`return NULL;`
`794`	`793`	`Py_INCREF(to->dataobj);`