Skip to content

tty.setraw() and tty.setcbreak() return partially modified original attributes #110392

Closed
@serhiy-storchaka

Description

@serhiy-storchaka

Bug report

According to the documentation they save the original result of termios.tcgetattr() and return it. But while making a copy of the attribute list before modifying it they do not take in account that it contains a reference to original cc list and modify it. So these functions return a list which contains original values and modified cc list.

These functions started returning the attribute list in #85984 (486bc8e).

The question: who should make a copy of the internal list: setraw() before passing it to cfmakeraw(), or cfmakeraw() itself?

cc @gpshead

Linked PRs

Metadata

Metadata

Labels

3.12only security fixes3.13bugs and security fixestype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions