Skip to content

Refactor tests to split out common test types #111673

Closed as not planned
Closed as not planned
@skirpichev

Description

@skirpichev

It is better to not import from one test in other tests, I propose adding a utils module for common types / helpers.

Originally posted by @sobolevn in #111624 (comment)

For example:

class float2:
def __init__(self, value):
self.value = value
def __float__(self):
return self.value

and
class Float:
def __float__(self):
return 4.25

class BadFloat:
def __float__(self):
return 687
class BadFloat2:
def __float__(self):
return FloatSubclass(4.25)
class BadFloat3(float):
def __float__(self):
return FloatSubclass(4.25)

we could unify to:

class FloatLike:
    def __init__(self, value):
        self.value = value

    def __float__(self):
        return self.value

Such support classes now scattered e.g. in Lib/test_float.py and in Lib/test_capi/test_getargs.py.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions