Skip to content

Windows test scripts don't escape commas properly #115556

Closed
@ambv

Description

@ambv

In Windows batch file execution, a comma is one of the magic parameter delimiters. To pass a comma as parameter data, you have to use string quotes around that parameter, like:

.\Tools\buildbot\test.bat -M33g "-uall,extralargefile" test_zipfile64

However, now the quotes become part of the parameter. Inside test.bat we employ some command-line parsing and shifting, which requires us to remove the quotes from parameters, if any, for the code to continue working.

This is doubly complicated by the fact that test.bat passes execution to rt.bat, which does similar parsing there. The fix is needed there, too.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-build

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions