sockaddr_hci lacks hci_channel (AF_BLUETOOTH sockets)

[mikeryan]

BPO	25957
Nosy	@vstinner

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2015-12-26.19:35:41.319>
labels = ['extension-modules', 'type-bug', 'library']
title = 'sockaddr_l2 lacks CID, address type (AF_BLUETOOTH sockets)'
updated_at = <Date 2021-06-01.09:20:35.829>
user = 'https://bugs.python.org/mikeryan'

bugs.python.org fields:

activity = <Date 2021-06-01.09:20:35.829>
actor = 'steve.dower'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'Library (Lib)']
creation = <Date 2015-12-26.19:35:41.319>
creator = 'mikeryan'
dependencies = []
files = []
hgrepos = []
issue_num = 25957
keywords = []
message_count = 2.0
messages = ['257043', '257120']
nosy_count = 2.0
nosy_names = ['vstinner', 'mikeryan']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25957'
versions = ['Python 2.7']

Linked PRs

• gh-70145: Add support for channels in Bluetooth HCI protocol #132481

[mikeryan]

The AF_BLUETOOTH socket type lacks support for specifying CID and address type in sockaddr_l2. These structure members have been present since 2009 and 2012 respectively:

https://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=3de95535
https://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=ba801fcd

The current version of the full structure can be found here:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/lib/l2cap.h?id=1b9e48f4#n40

The Python code in question can be found here:

https://github.com/python/cpython/blob/4f9794dbcaa6ee7ddc6ab175a57e7f01ebe64353/Modules/socketmodule.c#L1108

[mikeryan]

AF_BLUETOOTH also lacks support for hci_channel in sockaddr_hci for BTPROTO_HCI sockets:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/lib/hci.h?h=5.37#n2340

This feature has been present in BlueZ since 2010:

https://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=12d02e7f

(Note that the latest BlueZ release includes a total of five different channels that should be supported)

[encukou]

CID and address type were added in #129288.

[serhiy-storchaka]

TODO: add support for hci_channel in sockaddr_hci for BTPROTO_HCI sockets.

The code will be complicated, because currently only a single bytes/int value is accepted as an address, not a tuple. See also #69232.

[serhiy-storchaka]

Note that there were bugs in support of BTPROTO_HCI sockets.

• Incorrect support on FreeBSD (which should be close to NetBSD than to Linux). Presumably fixed by PR gh-111178: Fix getsockaddrarg() undefined behavior #131668.
• hci_channel was not initialized. That made the feature unusable on Fedora based distributives. See Possible use of unitialized socked address #132075.