OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()

[tiran]

BPO	42854
Nosy	@tiran, @ethanfurman, @pablogsal, @miss-islington, @FFY00, @geofft
PRs	bpo-42854: Use SSL_read/write_ex() (GH-25468) #25468 bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write #27271 [3.10] bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write (GH-27271) #27308

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2021-07-23.15:26:03.224>
created_at = <Date 2021-01-07.08:23:09.806>
labels = ['easy', 'expert-SSL', 'type-feature', '3.10']
title = 'OpenSSL 1.1.1: use SSL_write_ex() and SSL_read_ex()'
updated_at = <Date 2021-07-23.15:26:03.937>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2021-07-23.15:26:03.937>
actor = 'pablogsal'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2021-07-23.15:26:03.224>
closer = 'pablogsal'
components = ['SSL']
creation = <Date 2021-01-07.08:23:09.806>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 42854
keywords = ['patch', 'easy (C)']
message_count = 13.0
messages = ['384567', '384568', '391295', '391358', '391363', '391422', '391521', '397822', '397832', '397833', '397906', '398063', '398068']
nosy_count = 6.0
nosy_names = ['christian.heimes', 'ethan.furman', 'pablogsal', 'miss-islington', 'FFY00', 'geofft']
pr_nums = ['25468', '27271', '27308']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue42854'
versions = ['Python 3.10']

Linked PRs

• gh-87020: Revert "use SSL_write/read_ex() GH-27271, GH-25468" #95593
• [3.11] gh-87020: Revert "Use SSL_write/read_ex() GH-27271, GH-25468" #95594

[tiran]

SSL_read() and SSL_write() are limited to int. The new SSL_write_ex() and SSL_read_ex() APIs support size_t just like read(2) and recv(2). Also see bpo-42853.

int SSL_write_ex(SSL *s, const void *buf, size_t num, size_t *written);
int SSL_read_ex(SSL *ssl, void *buf, size_t num, size_t *readbytes);

Both functions return 1 for success or 0 for failure.

[tiran]

As of version 3.3.1, LibreSSL does not have SSL_write_ex() and SSL_read_ex(). The read and write functions are limited to int.

[tiran]

3.10 branch now requires OpenSSL 1.1.1. This should be easy to implement.

[tiran]

SSL_write_ex() and SSL_read_ex() solve two issues:

• bpo-42853: SSLSocket no longer raises overflow error when sending or receiving more than 2 GB of data
• bpo-31711: empty send(b"") no longer fails with protocol violation exception

[tiran]

New changeset 89d1550 by Christian Heimes in branch 'master':
bpo-42854: Use SSL_read/write_ex() (GH-25468)
89d1550

[tiran]

Ethan, what's your platform and OpenSSL version?

[ethanfurman]

False alarm, sorry. Still getting used to merging, rebasing, etc.

Current tests run fine.