Infinite recursion in Pickler.persistent_id

[embe]

BPO	45687
Nosy	@serhiy-storchaka, @embe
Files	pickle-bug.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2021-11-02.08:21:56.849>
labels = ['interpreter-core', 'type-bug', '3.9', '3.10', '3.11', 'library']
title = 'Infinite recursion in Pickler.persistent_id'
updated_at = <Date 2021-11-02.09:16:16.272>
user = 'https://github.com/embe'

bugs.python.org fields:

activity = <Date 2021-11-02.09:16:16.272>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core', 'Library (Lib)']
creation = <Date 2021-11-02.08:21:56.849>
creator = 'embe-navalgo'
dependencies = []
files = ['50418']
hgrepos = []
issue_num = 45687
keywords = []
message_count = 1.0
messages = ['405494']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'embe-navalgo']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45687'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

Linked PRs

• gh-89850: Remove reconstruct_method from Pickler_get_persid #100350
• gh-89850: Add default C implementations of persistent_id() and persistent_load() #113579

[embe]

The following code, which seems reasonable:

import io
import pickle

class Pickler(pickle.Pickler):
  def persistent_id(self, obj):
    return super().persistent_id(obj)

Pickler(io.BytesIO()).dump(42)

crashes with:
RecursionError: maximum recursion depth exceeded while calling a Python object

It works perfectly when inheriting from pickle._Pickler (the Python implementation).