TimedRotatingFileHandler "midnight" misleading when interval > 1

[mschiess]

BPO	46377
Nosy	@vsajip
PRs	bpo-46377: TimedRotatingFileHandler fix to ignore interval when "midnight" is given #30599

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-01-14.13:50:48.156>
labels = ['type-feature', 'library', '3.11']
title = 'TimedRotatingFileHandler "midnight" misleading when interval > 1'
updated_at = <Date 2022-01-14.18:25:21.751>
user = 'https://bugs.python.org/mschiess'

bugs.python.org fields:

activity = <Date 2022-01-14.18:25:21.751>
actor = 'mschiess'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-01-14.13:50:48.156>
creator = 'mschiess'
dependencies = []
files = []
hgrepos = []
issue_num = 46377
keywords = ['patch']
message_count = 5.0
messages = ['410558', '410565', '410567', '410571', '410583']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'python-dev', 'mschiess']
pr_nums = ['30599']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46377'
versions = ['Python 3.11']

Linked PRs

• gh-90535: Warn of deprecation of intervals other than 1 with when='MIDNIGHT' #98099
• gh-90535: Fix support of interval>1 in logging.TimedRotatingFileHandler #116220
• [3.12] gh-90535: Fix support of interval>1 in logging.TimedRotatingFileHandler (GH-116220) #116892
• [3.11] gh-90535: Fix support of interval>1 in logging.TimedRotatingFileHandler (GH-116220) #116893

[mschiess]

Using the TimedRotatingFileHandler along with "when='midnight'" and interval > 1, midnight is handled equally to "days" which is a little misleading.

Expectation:
setting when to 'midnight', the file is rotated every midnight (interval value should be ignored)

Current behavior:
If 'midnight' is given alongside with an interval greater than 1 (.e.g 5), the (internal) interval (24*60*60) is calculated with the given interval -> 24*60*60 * 5.

In my case, this led to some unforeseeable and unexpected behavior.