PyCode_Addr2Location bogus assert(?) or invalid branch?

[Fidget-Spinner]

In https://github.com/python/cpython/blob/main/Objects/codeobject.c#L971-L975, addrq < 0 is a condition but the assert following the branch fails when addrq < 0. This causes mypyc to segfault on 3.11 debug.

[Fidget-Spinner]

I think the branch is supposed to return 0 or 1. (Not sure which).

[markshannon]

There are no tests for PyCode_Addr2Location and it is undocumented. 🤷

Returning 0 with an exception if addrq < 0 seems the better API, but at this stage in 3.11, returning 1 for success seems safer.

[markshannon]

Returning 1 seems consistent with the original implementation for #88116, so let's go with that.