Skip to content

GH-88597: Rename uuid's new CLI args to be in line with uuidgen. #101248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

achhina
Copy link
Contributor

@achhina achhina commented Jan 22, 2023

Follow-up patch in regards to the proposed changes mentioned here.

❯ ./python.exe -m uuid -h          
usage: uuid.py [-h] [-u {uuid1,uuid3,uuid4,uuid5}] [-n NAMESPACE] [-N NAME]

Generates a uuid using the selected uuid function.

options:
  -h, --help            show this help message and exit
  -u {uuid1,uuid3,uuid4,uuid5}, --uuid {uuid1,uuid3,uuid4,uuid5}
                        The function to use to generate the uuid. By default uuid4 function is used.
  -n NAMESPACE, --namespace NAMESPACE
                        The namespace is a UUID, or '@ns' where 'ns' is a well-known predefined UUID addressed by namespace name. Such as @dns,
                        @url, @oid, and @x500. Only required for uuid3/uuid5 functions.
  -N NAME, --name NAME  The name used as part of generating the uuid. Only required for uuid3/uuid5 functions.

@achhina
Copy link
Contributor Author

achhina commented Jan 22, 2023

Hi @gpshead, would you be able to take a look at this when you get a chance?

@gpshead
Copy link
Member

gpshead commented Jan 23, 2023

I think this looks good, I looped @serhiy-storchaka in to see if he's got any more suggestions.

@gpshead gpshead self-assigned this Jan 23, 2023
@gpshead gpshead changed the title GH-88597: Rename uuid cli args and parameters to be in line with uuidgen. GH-88597: Rename uuid's new CLI args to be in line with uuidgen. Jan 23, 2023
@gpshead gpshead merged commit 952a1d9 into python:main Jan 25, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Jan 25, 2023
python#101248)

this way they match an existing uuidgen command line tool.
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
python#101248)

this way they match an existing uuidgen command line tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants