Skip to content

GH-89091: raise RuntimeWarning for unawaited async generator methods #104611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2023

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 18, 2023

@kumaraditya303 kumaraditya303 requested a review from gvanrossum May 18, 2023 12:57
@markshannon
Copy link
Member

Adding finalization to objects created for every async for loop is likely to have an adverse effect on performance.
Have you benchmarked this?

@kumaraditya303
Copy link
Contributor Author

Running https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_async_generators/run_benchmark.py shows Benchmark hidden because not significant (1): async_generators. My benchmarking setup isn't very accurate though.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See my analysis in GH-89091.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented May 26, 2023

I plan to land this later today if there are no further concerns.

@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 5e21e60 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-asyncio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants