-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
GH-89091: raise RuntimeWarning
for unawaited async generator methods
#104611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding finalization to objects created for every |
Running https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_async_generators/run_benchmark.py shows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See my analysis in GH-89091.
I plan to land this later today if there are no further concerns. |
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 5e21e60 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading. Please reload this page.