Skip to content

gh-92536: Remove PyUnicode_READY() calls #105210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2023
Merged

gh-92536: Remove PyUnicode_READY() calls #105210

merged 2 commits into from
Jun 1, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 1, 2023 •
edited by bedevere-bot
Loading

Since Python 3.12, PyUnicode_READY() does nothing and always returns 0.

@vstinner
pythongh-92536: Remove PyUnicode_READY() calls
63ba3dc 
Since Python 3.12, PyUnicode_READY() does nothing and always
returns 0.
@bedevere-bot bedevere-bot mentioned this pull request Jun 1, 2023
Closed
@vstinner vstinner mentioned this pull request Jun 1, 2023
Merged
@vstinner
Copy link
Member Author

vstinner commented Jun 1, 2023

See also PR #105208.

@vstinner vstinner merged commit ef30093 into python:main Jun 1, 2023
@vstinner vstinner deleted the remove_pyunicode_ready branch June 1, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot