Skip to content

Trivial: reformat code block in black style to make it easier to read #106965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

Trivial: reformat code block in black style to make it easier to read #106965

merged 1 commit into from
Jul 22, 2023

Conversation

itsthejoker
Copy link
Contributor

@itsthejoker itsthejoker commented Jul 21, 2023 •
edited by github-actions bot
Loading

Simply adjusts the layout of the most code-heavy example in errors.rst to be in the style of Black so that it's easier to see how everything is fitting together in the example and to render better on small screens.

📚 Documentation preview 📚: https://cpython-previews--106965.org.readthedocs.build/

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 21, 2023
@ghost
Copy link

ghost commented Jul 21, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@itsthejoker
Copy link
Contributor Author

itsthejoker commented Jul 21, 2023 •
edited
Loading

I can't complete the flow from @cpython-cla-bot because it reports an internal server error. It says I'm good to go now so 🤷

@ambv
Copy link
Contributor

ambv commented Jul 22, 2023

nit: for exploding bracket pairs within other structures, Black would actually put the trailing commas in everywhere.

@ambv ambv merged commit ed491d9 into python:main Jul 22, 2023
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 22, 2023
@miss-islington
Copy link
Contributor

Thanks @itsthejoker for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @itsthejoker for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @itsthejoker and @ambv, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker ed491d9f782480fb00535abcf667027e0e323287 3.11

@bedevere-bot
Copy link

GH-107010 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@itsthejoker @miss-islington
Reformat code block to make it easier to read (pythonGH-106965)
9476d7f 
(cherry picked from commit ed491d9)

Co-authored-by: Joe Kaufeld <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
@itsthejoker @ambv
[3.11] Reformat code block to make it easier to read (pythonGH-106965)
f650ee3 
(cherry picked from commit ed491d9)

Co-authored-by: Joe Kaufeld <[email protected]>
@bedevere-bot
Copy link

GH-107022 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit that referenced this pull request Jul 22, 2023
@miss-islington @itsthejoker
[3.12] Reformat code block to make it easier to read (GH-106965) (#10…
e7757ab 
…7010)

(cherry picked from commit ed491d9)

Co-authored-by: Joe Kaufeld <[email protected]>
ambv added a commit that referenced this pull request Jul 22, 2023
@ambv @itsthejoker
[3.11] Reformat code block to make it easier to read (GH-106965) (#10…
c65ca70 
…7022)

(cherry picked from commit ed491d9)

Co-authored-by: Joe Kaufeld <[email protected]>
@itsthejoker itsthejoker deleted the patch-1 branch July 26, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsthejoker @ambv @miss-islington @bedevere-bot