Skip to content

gh-107253: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT #107254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-107253: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT #107254

wants to merge 3 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Open
@rhettinger rhettinger removed their request for review July 25, 2023 20:05
@encukou
Copy link
Member

encukou commented Nov 28, 2023

This is a behaviour change. It may break existing users.
It's OK to do the change in individual cases where the existing behaviour is problematic, but changing all the occurrences is just asking for trouble.
These are the cases that don't break tests, but IMO in many cases that means the tests are inadequate :)

Would you be OK closing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
awaiting core review DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @encukou @bedevere-bot