-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-107659: Add docstring for ctypes.POINTER & ctypes.ARRAY #107739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@bedevere-bot how can i improve this test. |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @bedevere-bot I did not understand what to do with Misc/News.d file what to add there and on which file |
No news entry is required on a PR like this; I've applied the "skip news" label to this PR, and as a result, @bedevere-bot has stopped complaining about the lack of news entry. Your PR appears to mean that Python no longer builds correctly, however, which is a more serious issue :) |
@AlexWaygood can i able to merge this, if not what to do |
Co-authored-by: Alex Waygood <[email protected]>
Modules/_ctypes/_ctypes.c
Outdated
@@ -4814,7 +4816,13 @@ PyTypeObject PyCArray_Type = { | |||
0, /* tp_setattro */ | |||
&PyCData_as_buffer, /* tp_as_buffer */ | |||
Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE, /* tp_flags */ | |||
PyDoc_STR("XXX to be provided"), /* tp_doc */ | |||
PyDoc_STRVAR(array_doc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is here. Please take a look at the usage of PyDoc_STRVAR
, you can search this in the source code of cpython :)
BTW. There is already a similar PR here.
Hi @CharlieZhao95 I fix the code as said, waiting for merging |
In light of #107697 this only updates the comment for A |
yes |
#107660 added a docstring for Sorry @Geekverma -- others were faster. |
gh-107659:Add docstring for ctypes.POINTER & ctypes.ARRAY
ctypes.pointer
andctypes.POINTER
#107659