Skip to content

gh-84805: Autogenerate signature for METH_NOARGS and METH_O extension functions #107794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2023
Merged

gh-84805: Autogenerate signature for METH_NOARGS and METH_O extension functions #107794

merged 5 commits into from
Aug 11, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 9, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 9, 2023
Closed
@erlend-aasland erlend-aasland self-requested a review August 9, 2023 07:49
erlend-aasland
erlend-aasland approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

@serhiy-storchaka
Copy link
Member Author

@erlend-aasland, do you have any opinion about the name of the single positional parameter in METH_O functions? I use object, but maybe there are better ideas? It does not affect execution, it only affects the help() output.

@erlend-aasland
Copy link
Contributor

@erlend-aasland, do you have any opinion about the name of the single positional parameter in METH_O functions? I use object, but maybe there are better ideas? It does not affect execution, it only affects the help() output.

I thought about it while reviewing, and I think object is fine. In any way, it is better than the current (...).

@ambv
Copy link
Contributor

ambv commented Aug 11, 2023

Closing and re-opening to retrigger CLA checks. Sorry for the noise.

@ambv ambv closed this Aug 11, 2023
@ambv ambv reopened this Aug 11, 2023
@serhiy-storchaka serhiy-storchaka merged commit 3901c99 into python:main Aug 11, 2023
@serhiy-storchaka serhiy-storchaka deleted the text-signature-meth-noargs-o branch August 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @erlend-aasland @ambv @bedevere-bot