Skip to content

gh-112625: Protect bytearray from being freed by misbehaving iterator inside bytearray.join #112626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chilaxan
Copy link
Contributor

@chilaxan chilaxan commented Dec 2, 2023

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
Copy link
Member

Would you mind to add a NEWS entry? You can use blurb-it for this.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) December 4, 2023 07:54
@serhiy-storchaka serhiy-storchaka merged commit 0e732d0 into python:main Dec 4, 2023
@miss-islington-app
Copy link

Thanks @chilaxan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112693 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2023
…erator inside bytearray.join (pythonGH-112626)

(cherry picked from commit 0e732d0)

Co-authored-by: chilaxan <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2023
…erator inside bytearray.join (pythonGH-112626)

(cherry picked from commit 0e732d0)

Co-authored-by: chilaxan <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 4, 2023

GH-112694 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 4, 2023
serhiy-storchaka pushed a commit that referenced this pull request Dec 4, 2023
…terator inside bytearray.join (GH-112626) (GH-112694)

(cherry picked from commit 0e732d0)

Co-authored-by: chilaxan <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Dec 4, 2023
…terator inside bytearray.join (GH-112626) (GH-112693)

(cherry picked from commit 0e732d0)

Co-authored-by: chilaxan <[email protected]>
@chilaxan chilaxan deleted the fix-bytearray.join-Read-After-Free branch December 4, 2023 16:47
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants