Skip to content

gh-115823: Calculate correctly error locations when dealing with implicit encodings #115824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2024
Merged

gh-115823: Calculate correctly error locations when dealing with implicit encodings #115824

merged 2 commits into from
Feb 26, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 22, 2024 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 22, 2024
@bedevere-app bedevere-app bot mentioned this pull request Feb 22, 2024
Closed
lysnikolaou
lysnikolaou reviewed Feb 26, 2024
View reviewed changes
lysnikolaou
lysnikolaou approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal enabled auto-merge (squash) February 26, 2024 12:50
@pablogsal pablogsal merged commit 015b97d into python:main Feb 26, 2024
@pablogsal pablogsal deleted the bad_encodings branch February 26, 2024 12:57
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2024
@pablogsal @miss-islington
pythongh-115823: Calculate correctly error locations when dealing wit…
1767e6b 
…h implicit encodings (pythonGH-115824)

(cherry picked from commit 015b97d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2024

GH-115949 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2024
@pablogsal @miss-islington
pythongh-115823: Calculate correctly error locations when dealing wit…
c4d2b6d 
…h implicit encodings (pythonGH-115824)

(cherry picked from commit 015b97d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 26, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2024

GH-115950 is a backport of this pull request to the 3.11 branch.

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 015b97d19a24a169cc3c0939119e1228791e4253 3.10

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 26, 2024
pablogsal added a commit that referenced this pull request Feb 26, 2024
@miss-islington @pablogsal
[3.12] gh-115823: Calculate correctly error locations when dealing wi…
1932da0 
…th implicit encodings (GH-115824) (#115949)

gh-115823: Calculate correctly error locations when dealing with implicit encodings (GH-115824)
(cherry picked from commit 015b97d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Feb 26, 2024
@miss-islington @pablogsal
[3.11] gh-115823: Calculate correctly error locations when dealing wi…
35a43d4 
…th implicit encodings (GH-115824) (#115950)

gh-115823: Calculate correctly error locations when dealing with implicit encodings (GH-115824)
(cherry picked from commit 015b97d)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@pablogsal @woodruffw
pythongh-115823: Calculate correctly error locations when dealing wit…
ff5040d 
…h implicit encodings (python#115824)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@pablogsal @adorilson
pythongh-115823: Calculate correctly error locations when dealing wit…
f3f5478 
…h implicit encodings (python#115824)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@pablogsal @diegorusso
pythongh-115823: Calculate correctly error locations when dealing wit…
57af7fc 
…h implicit encodings (python#115824)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@pablogsal @LukasWoodtli
pythongh-115823: Calculate correctly error locations when dealing wit…
e4f52c9 
…h implicit encodings (python#115824)
@hugovk hugovk removed the needs backport to 3.10 only security fixes label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @lysnikolaou @hugovk