-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-118710: IPv*Address
class properties
#120698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add .. versionchanged:: 3.14 annotations to the Doc/library/ipaddress.rst description of these attributes mentioning that they are now available on the class as well as instances.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
gpshead, I have made the requested changes; please review again. |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
…4-45-38.gh-issue-118710.5GZZPX.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
IPv{4,6}Address.version
andmax_prefixlen
available on classes, not just instances #118710📚 Documentation preview 📚:
library/ipaddress.html#ipaddress.IPv4Address.version