Skip to content

Revert "gh-120057: Add os.environ.refresh() method (#120059)" #120790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 20, 2024

This reverts commit 7aff2de.

The function is controversial and it was decided to remove it.


📚 Documentation preview 📚: https://cpython-previews--120790.org.readthedocs.build/

…)"

This reverts commit 7aff2de.

The function is controversial and it was decided to remove it.
@nineteendo
Copy link
Contributor

The discussion on the discourse thread hasn't concluded: a better name might make it more intuitive.

@vstinner vstinner marked this pull request as draft June 20, 2024 19:13
@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2024

According to https://discuss.python.org/t/method-to-refresh-os-environ/54774/101 poll, the majority prefers to keep the method and prefers the name refresh() for the method.

@vstinner vstinner closed this Jul 8, 2024
@vstinner vstinner deleted the revert_environ branch July 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants