Skip to content

gh-120057: Rename os.environ.refresh() to invalidate_cache() #120808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 20, 2024

@barneygale
Copy link
Contributor

barneygale commented Jun 20, 2024

reload_from_process() maybe?

@vstinner
Copy link
Member Author

reload_from_process() maybe?

@barneygale: I suggest you to propose other names in https://discuss.python.org/t/method-to-refresh-os-environ/54774 discussion.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably get an acknowledgement from someone who might argue against this before merging.

@vstinner
Copy link
Member Author

cc @erlend-aasland

@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2024

According to https://discuss.python.org/t/method-to-refresh-os-environ/54774/101 poll, refresh() name is the favorite name. I close this issue.

@vstinner vstinner closed this Jul 8, 2024
@vstinner vstinner deleted the env_invalidate_cache branch July 8, 2024 09:19
@zooba
Copy link
Member

zooba commented Jul 8, 2024

Votes in Ideas are not binding, they're just informative. You should take the proposal to Core Development and see what the actual team thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants