Skip to content

bpo-33944: Add site.py site-packages tracing in verbose mode #12110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 12, 2020
Merged

bpo-33944: Add site.py site-packages tracing in verbose mode #12110

merged 10 commits into from
Jun 12, 2020

Conversation

native-api
Copy link
Contributor

@native-api native-api commented Mar 1, 2019 •
edited by bedevere-bot
Loading

methane
methane reviewed Mar 2, 2019
View reviewed changes
methane
methane reviewed Mar 2, 2019
View reviewed changes
methane and others added 2 commits March 2, 2019 20:28
@methane @native-api
code style fix
793a6a5 
Co-Authored-By: native-api <[email protected]>
@methane @native-api
use newer string formatting syntax
2b77747 
Co-Authored-By: native-api <[email protected]>
@methane
Copy link
Member

methane commented Mar 3, 2019

I didn't mean single place. I meant changing all % usages.

@native-api
Copy link
Contributor Author

@methane: I didn't mean single place. I meant changing all % usages.

Well, the suggested change feature commits exactly what you suggested (I don't actually know if I can change it at all), and I didn't look any further, trusting your review.
Could you please do the task to completion? There may be yet other small things to fix or something.

@methane
Copy link
Member

methane commented Mar 3, 2019

and I didn't look any further, trusting your review.

Please don't trust me as such. I hope contributors is not robot just applying suggested change. I hope contributors understand and grow up by review.

Could you please do the task to completion? There may be yet other small things to fix or something.

At a code level, looks good me.
But I'm not sure that adding more PYTHON* env vars is really good thing for this particular case...

Adding more and more envvar makes it harder to users read manual and find option they needed by their self.

remilapeyre
remilapeyre reviewed Jun 6, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @native-api !

remilapeyre
remilapeyre reviewed Jun 8, 2020
View reviewed changes
@native-api
Update Doc/using/cmdline.rst
bf76e64 
Co-authored-by: Rémi Lapeyre <[email protected]>
@methane methane merged commit 2145c8c into python:master Jun 12, 2020
@native-api native-api deleted the site_trace branch June 12, 2020 12:20
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@native-api @arun-mani-j
bpo-33944: site: Add site-packages tracing in verbose mode (pythonGH-…
71ad609 
…12110)
@warsaw warsaw mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane left review comments

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@native-api @methane @remilapeyre @the-knights-who-say-ni @bedevere-bot