Skip to content

gh-123424: add ZipInfo._for_archive to set suitable default properties #123429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 29, 2024
Merged

gh-123424: add ZipInfo._for_archive to set suitable default properties #123429

merged 8 commits into from
Dec 29, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 28, 2024 •
edited by jaraco
Loading

@picnixz picnixz requested a review from jaraco as a code owner August 28, 2024 14:20
@bedevere-app bedevere-app bot mentioned this pull request Aug 28, 2024
Closed
jaraco
jaraco reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.

@Wulian233
Copy link
Contributor

Is there anything else that needs to be changed/discussion in this PR? I had another PR #124435 (which has been completed) that conflicted with these changes.

After merge, I can continue handle my PR :)

#124435 (review)

@picnixz
Copy link
Member Author

picnixz commented Nov 2, 2024

I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least).

@jaraco jaraco self-assigned this Dec 29, 2024
@jaraco jaraco force-pushed the feat/zipfile-for-name-123424 branch from f578f66 to 44e7b75 Compare December 29, 2024 18:07
@jaraco jaraco changed the title gh-123424: add ZipInfo.for_name to construct a ZipInfo for a file in an archive gh-123424: add ZipInfo._for_archive to set suitable default properties Dec 29, 2024
@jaraco jaraco enabled auto-merge (squash) December 29, 2024 18:23
@jaraco jaraco merged commit 7e819ce into python:main Dec 29, 2024
42 checks passed
@picnixz
Copy link
Member Author

picnixz commented Dec 31, 2024

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

@picnixz picnixz deleted the feat/zipfile-for-name-123424 branch December 31, 2024 17:27
@jaraco
Copy link
Member

jaraco commented Dec 31, 2024

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

No need to apologize. Thanks for the original work and being proactive about your availability.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@picnixz @jaraco @srinivasreddy
pythongh-123424: add ZipInfo._for_archive to set suitable default p…
7c0567d 
…roperties (python#123429)

---------

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco jaraco mentioned this pull request May 12, 2025
Closed
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz @jaraco
Cherry-pick changes from python/cpython#123429.
bc37b6e 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <[email protected]>
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
@picnixz @jaraco
Cherry-pick changes from python/cpython#123429.
511a7a3 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco jaraco mentioned this pull request May 26, 2025
Merged
jaraco added a commit to jaraco/zipp that referenced this pull request May 26, 2025
@jaraco
Merge pull request #142 from jaraco/backport-gh-123429
73cdd55 
Backport python/cpython#123429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

Assignees

@jaraco jaraco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract ZipInfo for archive functionality
3 participants
@picnixz @Wulian233 @jaraco