gh-52551: Use wcsftime() to implement time.strftime() on Windows #125658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Oct 18, 2024
Modules/timemodule.c
Outdated
| @@ -740,8 +740,7 @@ checktm(struct tm* buf) | |||
| } | |||
|
|
|||
| #ifdef MS_WINDOWS | |||
| /* wcsftime() doesn't format correctly time zones, see issue #10653 */ | |||
| # undef HAVE_WCSFTIME | |||
| # define HAVE_WCSFTIME | |||
There was a problem hiding this comment.
There are compiler warnings: 'HAVE_WCSFTIME': macro redefinition [D:\a\cpython\cpython\PCbuild_freeze_module.vcxproj]
There was a problem hiding this comment.
Oh, I did not find where it was defined in C.
|
Is #54862 issue solved on Windows? |
What exactly is that issue about? I get no mojibake: >>> import time
>>> time.strftime('%Z')
'Фінляндія (літо)'
>>> time.tzname
('Фінляндія (зима)', 'Фінляндія (літо)')But it crashes on invalid format string (like |
Well, this was unrelated. |
I changed my Windows language to French and the timezone to UTC+14, I managed to get a non-ASCII timezone name: So at least for this locale (French_France.1252), it works as expected. |
|
Thank you for your review @vstinner. |
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.