-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-126139: Improve error message location for future statement with unknown feature #126140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126139: Improve error message location for future statement with unknown feature #126140
Conversation
@pablogsal Would you backdoort this? |
To 3.11? Unfortunately as much as I want we are past bug fix period and I don't think this qualifies as a security fix :( |
To other branches yes: I think this easily qualifies as a bug fix |
Thanks @brianschubert for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…with unknown feature (pythonGH-126140) (cherry picked from commit 224c370) Co-authored-by: Brian Schubert <[email protected]>
Sorry, @brianschubert and @iritkatriel, I could not cleanly backport this to
|
GH-126155 is a backport of this pull request to the 3.13 branch. |
This will require a manual backport to 3.12. |
…with unknown feature (python#126140) (cherry picked from commit 224c370)
…tement with unknown feature (pythonGH-126140) (cherry picked from commit 224c370) Co-authored-by: Brian Schubert <[email protected]>
…tement with unknown feature (pythonGH-126140) (cherry picked from commit 224c370) Co-authored-by: Brian Schubert <[email protected]>
GH-126160 is a backport of this pull request to the 3.12 branch. |
…with unknown feature (python#126140)
…with unknown feature (python#126140)
Fixes #126139
The error location is now set to the location of the undefined feature name:
I wasn't sure if this is noteworthy enough for a What's New entry. Let me know if I should add one.