Skip to content

gh-123967: Fix faulthandler for trampoline frames #127329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

gh-123967: Fix faulthandler for trampoline frames #127329

merged 1 commit into from
Nov 27, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 27, 2024 •
edited by bedevere-app bot
Loading

@vstinner
pythongh-123967: Fix faulthandler for trampoline frames
5c927f2 
If the top-most frame is a trampoline frame, skip it.
@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 27, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 27, 2024
Closed
@vstinner
Copy link
Member Author

@colesbury: Would you mind to review my fix?

@vstinner vstinner merged commit 58e334e into python:main Nov 27, 2024
50 checks passed
@vstinner vstinner deleted the faulthandler_owned branch November 27, 2024 15:14
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 27, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 27, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@vstinner vstinner added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Nov 28, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2024
@vstinner @miss-islington
pythongh-123967: Fix faulthandler for trampoline frames (pythonGH-127329
8f444d2 
)

If the top-most frame is a trampoline frame, skip it.
(cherry picked from commit 58e334e)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 28, 2024

GH-127362 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 28, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Nov 28, 2024
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 58e334e1431b2ed6b70ee42501ea73e08084e769 3.12

@bedevere-app
Copy link

bedevere-app bot commented Nov 28, 2024

GH-127363 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 28, 2024
vstinner added a commit that referenced this pull request Nov 28, 2024
@vstinner
[3.12] gh-123967: Fix faulthandler for trampoline frames (#127329) (#…
f4c9f39 
…127363)

gh-123967: Fix faulthandler for trampoline frames (#127329)

If the top-most frame is a trampoline frame, skip it.

(cherry picked from commit 58e334e)
vstinner added a commit that referenced this pull request Nov 30, 2024
@miss-islington @vstinner
[3.13] gh-123967: Fix faulthandler for trampoline frames (GH-127329) (#…
089d706 
…127362)

gh-123967: Fix faulthandler for trampoline frames (GH-127329)

If the top-most frame is a trampoline frame, skip it.
(cherry picked from commit 58e334e)

Co-authored-by: Victor Stinner <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@vstinner @ebonnal
pythongh-123967: Fix faulthandler for trampoline frames (python#127329)
9d35446 
If the top-most frame is a trampoline frame, skip it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @colesbury