Skip to content

gh-127627: Add posix._emscripten_debugger function #127628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2024
Merged

gh-127627: Add posix._emscripten_debugger function #127628

merged 4 commits into from
Dec 6, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 5, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 5, 2024
Closed
@hoodmane hoodmane requested a review from freakboy3742 December 5, 2024 09:13
@hoodmane hoodmane changed the title gh-127627: Add os._emscripten_debugger function gh-127627: Add posix._emscripten_debugger function Dec 5, 2024
@hoodmane
Copy link
Contributor Author

hoodmane commented Dec 5, 2024

I guess since it's private it doesn't make it onto the os module.

mdboom
mdboom approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

freakboy3742
freakboy3742 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems like a straightforward addition. I guess it makes sense to keep it private initially; it's easy enough to promote to a public API if it seems worthwhile to do so in future.

@freakboy3742 freakboy3742 merged commit 25eee57 into python:main Dec 6, 2024
41 checks passed
@hoodmane
Copy link
Contributor Author

hoodmane commented Dec 6, 2024

I suspect this is very niche -- it's useful for debugging and fixing faulty emscripten syscalls. But perhaps other people will find more common uses for it.

@hoodmane hoodmane deleted the emscripten-debugger branch December 6, 2024 11:45
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127627: Add posix._emscripten_debugger function (python#12…
a19645c 
…7628)

Add a posix._emscripten_debugger function to add an emscripten breakpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@mdboom mdboom mdboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoodmane @freakboy3742 @mdboom