gh-82987: Stop on calling frame unconditionally for inline breakpoints

[gaogaotiantian]

The testing code

import pdb
def foo():
    x = 40 + 2
    pdb.Pdb(skip=['__main__']).set_trace()
foo()

seems a bit silly, but this is a real issue because we use the last instance of pdb for inline breakpoints now.

So if we instantiate a debugger like p = pdb.Pdb(skip=["django.*"]) somewhere, and we set an inline breakpoint in Django with an innocent breakpoint(), it still won't stop inside Django modules.

Overall I think it's reasonable that we always stop for inline breakpoints. The implementation I chose is to remove the condition for opcode events which also makes sense. For now that event is exclusively used by inline breakpoints. Even if we add instruction level debugging in the future, I think the only useful command is "step instruction". It's hard to imagine instruction level breakpoints or something like until instruction. Always trigger user function for opcode seems like an okay solution.

• Issue: "pdb.Pdb(skip=…).set_trace()" should always stop on calling frame #82987

[iritkatriel]

This is probably worth a what's new entry.

[iritkatriel]

And a versionchange comment in the doc?

[gaogaotiantian]

Done

[iritkatriel]

"if ... are used" could be misunderstood to mean that skip will always be ignored if those are ever used.

[gaogaotiantian]

Will changing it to "when ... are used" better? Or we should just use the longer version from the news entry?

[iritkatriel]

I think "when .. are used" has the same problem, as does the longer version from the news entry.

[gaogaotiantian]

Inline breakpoints like :func:`breakpoint` or :func:`pdb.set_trace` will always stop the program at calling frame, ignoring the ``skip`` pattern (if any).

Is this better?

[iritkatriel]

Yes.

[gaogaotiantian]

Then I'll use this for all 3 places :)