gh-130637: Add validation for numeric response data in `stat()` method #130646

Mr-Sunglasses · 2025-02-27T18:17:23Z

fix: #130637

Issue: poplib.py: Missing integer parsing validation causes client crash on invalid server response #130637

… method

Mr-Sunglasses

It's a bug, i think it did not need a NEWS entry.

ericvsmith · 2025-02-28T00:49:47Z

This needs tests.

Mr-Sunglasses · 2025-02-28T09:54:31Z

This needs tests.

Hey @ericvsmith I've added then tests Thanks for the suggestion, Please Review it

Mr-Sunglasses

== Tests result: FAILURE ==

1 test altered the execution environment (env changed):
    test_ssl

1 test failed:
    test_importlib

23 tests OK.

Total duration: 5 min 25 sec
Total tests: run=6,169 failures=1 skipped=192
Total test files: run=25/25 failed=1 env_changed=1
Result: FAILURE
Error: Process completed with exit code 2.

This test is failing and I think it is not related to the changes in this PR.

Lib/poplib.py

Lib/test/test_poplib.py

bedevere-app · 2025-02-28T14:09:34Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ericvsmith · 2025-02-28T14:10:13Z

Also, I don't agree that there shouldn't be a NEWS entry. We put bug fixes in NEWS all the time.

Mr-Sunglasses · 2025-02-28T20:58:17Z

@ericvsmith I have made the requested changes; please review again.

bedevere-app · 2025-02-28T20:58:21Z

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

Mr-Sunglasses · 2025-02-28T20:58:35Z

Also, I don't agree that there shouldn't be a NEWS entry. We put bug fixes in NEWS all the time.

Add the NEWS entry, thanks.

ericvsmith

LGTM

miss-islington-app · 2025-03-02T13:05:43Z

Thanks @Mr-Sunglasses for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

… method (pythonGH-130646) (cherry picked from commit a42168d) Co-authored-by: Kanishk Pachauri <[email protected]> Co-authored-by: Eric V. Smith <[email protected]>

bedevere-app · 2025-03-02T13:05:53Z

GH-130763 is a backport of this pull request to the 3.13 branch.

… method (pythonGH-130646) (cherry picked from commit a42168d) Co-authored-by: Kanishk Pachauri <[email protected]> Co-authored-by: Eric V. Smith <[email protected]>

bedevere-app · 2025-03-02T13:05:57Z

GH-130764 is a backport of this pull request to the 3.12 branch.

…` method (GH-130646) (#130764) gh-130637: Add validation for numeric response data in `stat()` method (GH-130646) (cherry picked from commit a42168d) Co-authored-by: Kanishk Pachauri <[email protected]> Co-authored-by: Eric V. Smith <[email protected]>

…` method (GH-130646) (#130763) gh-130637: Add validation for numeric response data in `stat()` method (GH-130646) (cherry picked from commit a42168d) Co-authored-by: Kanishk Pachauri <[email protected]> Co-authored-by: Eric V. Smith <[email protected]>

… method (python#130646) Co-authored-by: Eric V. Smith <[email protected]>

pythongh-130637: Add validation for numeric response data in stat()…

18dfd83

… method

Mr-Sunglasses requested a review from a team as a code owner February 27, 2025 18:17

bedevere-app bot added the awaiting review label Feb 27, 2025

bedevere-app bot mentioned this pull request Feb 27, 2025

poplib.py: Missing integer parsing validation causes client crash on invalid server response #130637

Closed

Mr-Sunglasses commented Feb 27, 2025

View reviewed changes

skirpichev added the skip news label Feb 28, 2025

tests: Add tests for numeric response data in stat() method

f23be89

Mr-Sunglasses commented Feb 28, 2025

View reviewed changes

ericvsmith requested changes Feb 28, 2025

View reviewed changes

Lib/poplib.py Show resolved Hide resolved

Lib/test/test_poplib.py Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting review labels Feb 28, 2025

Mr-Sunglasses added 4 commits March 1, 2025 02:16

fix: add doc comment to ensures compliance with RFC 1939

46bc8bd

tests: Add tests to ensure it follows RFC 1939

a43b2ae

chore: add NEWS entry for the change

513af11

fix: linting errors

dadeef1

bedevere-app bot added awaiting change review and removed awaiting changes labels Feb 28, 2025

bedevere-app bot requested a review from ericvsmith February 28, 2025 20:58

ericvsmith added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed skip news labels Mar 1, 2025

ericvsmith approved these changes Mar 1, 2025

View reviewed changes

bedevere-app bot removed the awaiting change review label Mar 1, 2025

bedevere-app bot added the awaiting merge label Mar 1, 2025

Merge branch 'main' into fix/130637

782d075

ericvsmith merged commit a42168d into python:main Mar 2, 2025
39 checks passed

bedevere-app bot removed the awaiting merge label Mar 2, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 2, 2025

bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 2, 2025

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025

pythongh-130637: Add validation for numeric response data in stat()…

a00022c

… method (python#130646) Co-authored-by: Eric V. Smith <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-130637: Add validation for numeric response data in `stat()` method #130646

gh-130637: Add validation for numeric response data in `stat()` method #130646

Uh oh!

Mr-Sunglasses commented Feb 27, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

Mr-Sunglasses left a comment

Uh oh!

ericvsmith commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

Mr-Sunglasses left a comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Feb 28, 2025

Uh oh!

ericvsmith commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

bedevere-app bot commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

ericvsmith left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 2, 2025

Uh oh!

bedevere-app bot commented Mar 2, 2025

Uh oh!

bedevere-app bot commented Mar 2, 2025

Uh oh!

Uh oh!

Uh oh!

gh-130637: Add validation for numeric response data in stat() method #130646

gh-130637: Add validation for numeric response data in stat() method #130646

Uh oh!

Conversation

Mr-Sunglasses commented Feb 27, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mr-Sunglasses left a comment

Choose a reason for hiding this comment

Uh oh!

ericvsmith commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

Mr-Sunglasses left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app bot commented Feb 28, 2025

Uh oh!

ericvsmith commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

bedevere-app bot commented Feb 28, 2025

Uh oh!

Mr-Sunglasses commented Feb 28, 2025

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 2, 2025

Uh oh!

bedevere-app bot commented Mar 2, 2025

Uh oh!

bedevere-app bot commented Mar 2, 2025

Uh oh!

Uh oh!

gh-130637: Add validation for numeric response data in `stat()` method #130646

gh-130637: Add validation for numeric response data in `stat()` method #130646

Mr-Sunglasses commented Feb 27, 2025 •

edited by bedevere-app bot

Loading