Skip to content

gh-131853: Fix test_msgfmt on big-endian platforms #131879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 29, 2025

Use a generated .mo file instead of a checked in one.

Use a generated .mo file instead of a checked in one.
@serhiy-storchaka
Copy link
Member Author

!buildbot s390x RHEL9 3.x

@bedevere-bot
Copy link

The regex 's390x RHEL9 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@serhiy-storchaka
Copy link
Member Author

!buildbot s390x

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1bd13c8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131879%2Fmerge

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x RHEL8 Refleaks PR
  • s390x Fedora Rawhide Clang PR
  • s390x Fedora Stable Clang PR
  • s390x Fedora Rawhide LTO PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide Clang Installed PR
  • s390x Fedora Stable Clang Installed PR
  • s390x RHEL9 PR
  • s390x RHEL9 LTO PR
  • s390x Fedora Stable LTO + PGO PR
  • s390x RHEL8 LTO PR
  • s390x Fedora Stable PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Rawhide PR
  • s390x Fedora Rawhide Refleaks PR
  • s390x Fedora Rawhide NoGIL PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Fedora Rawhide LTO + PGO PR
  • s390x RHEL9 LTO + PGO PR
  • s390x Fedora Stable LTO PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x RHEL8 PR

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for fixing my error! Sadly there is no big-endian CI :-(

@serhiy-storchaka
Copy link
Member Author

A simpler fix would be changing the "=" prefix to "<", but we don't test struct.unpack here. We test that msgfmt.py generates expected platform-depending binary header on all platforms.

@StanFromIreland
Copy link
Member

Buildbots passing :-)

@serhiy-storchaka serhiy-storchaka merged commit c6b1a07 into python:main Mar 29, 2025
66 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test_msgfmt-test_binary_header branch March 29, 2025 17:14
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…1879)

Use a generated .mo file instead of a checked in one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants