Skip to content

gh-132527: fix: include 'w' in error message for array typecodes #132587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Vaid07-Techy
Copy link

@Vaid07-Techy Vaid07-Techy commented Apr 16, 2025

gh-132527: Fix error message to include 'w' typecode in arraymodule.c

This PR fixes the ValueError message in arraymodule.c, adding 'w' to the list of valid typecodes. 'w' is currently a supported typecode, but it was missing from the error message when users tried to use it, causing confusion.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 16, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Apr 16, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@StanFromIreland
Copy link
Member

This should be closed.

A pr already exists: #132529

In the future please check for existing PR's before submitting your own, you should probably look over the devguide too.

@tomasr8 tomasr8 changed the title fix: include 'w' in error message for array typecodes gh-132527: fix: include 'w' in error message for array typecodes Apr 16, 2025
@tomasr8
Copy link
Member

tomasr8 commented Apr 16, 2025

Thanks for the contribution @Vaid07-Techy! Unfortunately, as Stan said, there's already a PR that fixes this.
You can see if there's an open PR by checking the Linked PRs section of the issue (usually at the bottom).

That said, don't let this discourage you! I invite you to check the issue tracker for other issues :)

@tomasr8 tomasr8 closed this Apr 16, 2025
@Vaid07-Techy
Copy link
Author

hey @StanFromIreland thanks for letting me know, as I'm new here I'm still learning how everything works here ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants