Skip to content

gh-133253: making linecache thread-safe #133305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

gh-133253: making linecache thread-safe #133305

merged 2 commits into from
May 9, 2025

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented May 2, 2025 •
edited
Loading

Fixes #133253

Description:

  • Making linecache thread-safe

cc @colesbury

@python-cla-bot
Copy link

python-cla-bot bot commented May 2, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 2, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

hawkinsp
hawkinsp suggested changes May 2, 2025
View reviewed changes
Copy link
Contributor

@hawkinsp hawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking in your tests, somewhere?

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch from a19749b to 67bfa7d Compare May 2, 2025 20:16
@bedevere-app
Copy link

bedevere-app bot commented May 2, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch 3 times, most recently from 690f5a8 to ff93d54 Compare May 5, 2025 10:46
@vfdev-5 vfdev-5 marked this pull request as ready for review May 5, 2025 10:46
@vfdev-5
Copy link
Contributor Author

vfdev-5 commented May 5, 2025

@rhettinger could you please review this PR fixing the data race in linecache (issue 133253) or suggest a right person for the code review. Thanks!

@colesbury colesbury requested a review from rhettinger May 5, 2025 15:46
colesbury
colesbury approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'd appreciate @rhettinger's review

@vfdev-5 vfdev-5 force-pushed the make-linecache-threadsafe branch from ff93d54 to f4fe446 Compare May 5, 2025 19:21
@kumaraditya303 kumaraditya303 merged commit 8054184 into python:main May 9, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkinsp hawkinsp hawkinsp requested changes

@colesbury colesbury colesbury approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race in linecache under free-threading
4 participants
@vfdev-5 @hawkinsp @colesbury @kumaraditya303